Matthew Jacobs has posted comments on this change. Change subject: IMPALA-1769: Added hostname to all cgroup failure messages. ......................................................................
Patch Set 2: In addition to what Juan said, I think it's misleading to have the error messages indicate that the path is prefixed by the hostname. I see that it's convenient to print it out like that, but a better fix would be to modify the messages to say "path: _PATH_ on host: _HOST_". That said, this code shouldn't be exercised in supported scenarios anymore (we've unsupported Llama), and we will probably remove this code and all other llama-related code for C6 (if not sooner), so I don't think we should spend much time on this. I'd vote to close the JIRA as won't fix. -- To view, visit http://gerrit.cloudera.org:8080/1226 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I815a6c9b361e2351b97f153999674455cc700b56 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: No
