Michael Ho has posted comments on this change.

Change subject: Fix LLVM linker bug
......................................................................


Patch Set 3:

(2 comments)

I am not super familiar with the context on why the linker distinguishes 
between opaque and non-opaque type to begin with but this change seems to make 
sense.

http://gerrit.cloudera.org:8080/#/c/2656/3//COMMIT_MSG
Commit Message:

Line 20: the first structurally
       : identical type.
Did you mean opaque or non-opaque type here ? If so, it would be great to 
provide more details.


Line 25: istinct 
distinct


-- 
To view, visit http://gerrit.cloudera.org:8080/2656
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8aef7f79c8d905b267f5acc3392384b1b333e7d3
Gerrit-PatchSet: 3
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Casey Ching <[email protected]>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Michael Ho <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: Yes

Reply via email to