Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-2995: Fix apparent time-travel in timestamp expr-test ......................................................................
IMPALA-2995: Fix apparent time-travel in timestamp expr-test The expr test which tests unix_timestamp() after setting FLAGS_use_local_tz_for_unix_timestamp_conversions used a different method to get the 'before' and 'after' timestamps to unix_timestamp(). As a result, the 'after' timestamp may rarely be smaller than the value returned by unix_timestamp(). To fix this, I changed the expr-test logic to calculate the local timestamps in the same way as unix_timestamp(). Change-Id: I9773949cdac051b8bea4a9fb61695c2bc0948bc3 Reviewed-on: http://gerrit.cloudera.org:8080/2787 Reviewed-by: Casey Ching <[email protected]> Reviewed-by: Dan Hecht <[email protected]> Tested-by: Internal Jenkins --- M be/src/exprs/expr-test.cc 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Casey Ching: Looks good to me, but someone else must approve Internal Jenkins: Verified Dan Hecht: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/2787 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9773949cdac051b8bea4a9fb61695c2bc0948bc3 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Internal Jenkins
