Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3334: Fix some bugs in query options' parsing. ......................................................................
IMPALA-3334: Fix some bugs in query options' parsing. This change fixes two problems: 1. The query options OPTIMIZE_PARTITION_KEY_SCANS and DISABLE_STREAMING_PREAGGREGATIONS are both boolean so they should accept 'true' and '1' as input values. Previously, these two options are treated as int and value such as 'true' doesn't work with them. 2. The break statement in the case statement of the option SCAN_NODE_CODEGEN_THRESHOLD was 'stolen' by the option DISABLE_STREAMING_PREAGGREGATIONS when it was added. This change adds the missing break statement back for SCAN_NODE_CODEGEN_THRESHOLD. Change-Id: I5c74a1e5c49e3bda15a91b40740fc7310303207b Reviewed-on: http://gerrit.cloudera.org:8080/2776 Reviewed-by: Tim Armstrong <[email protected]> Reviewed-by: Dan Hecht <[email protected]> Tested-by: Internal Jenkins --- M be/src/service/query-options.cc M testdata/workloads/functional-query/queries/QueryTest/set.test 2 files changed, 96 insertions(+), 2 deletions(-) Approvals: Internal Jenkins: Verified Dan Hecht: Looks good to me, approved Tim Armstrong: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/2776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c74a1e5c49e3bda15a91b40740fc7310303207b Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Tim Armstrong <[email protected]>
