Dan Hecht has posted comments on this change. Change subject: IMPALA-1920: Fix userinfo and authority parsing. ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/2777/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 2242: "'AUTHORITY')", "example.com:80"); do we have a test case with no slash nor question mark? didn't notice that with a quick scan but maybe i missed it. http://gerrit.cloudera.org:8080/#/c/2777/2/be/src/util/url-parser.cc File be/src/util/url-parser.cc: Line 55: Several parts require finding the end of the authority just say: Find the end of the authority Line 67: if (0 <= first_question && first_question < first_slash) { else if - to make it explicit that these are mutually exclusive cases. alternatively, just combine these two conditionals using || Line 68: . (after the protocol) -- To view, visit http://gerrit.cloudera.org:8080/2777 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6486aecc7344f40d6f85d70960866fbb45bea2e1 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-HasComments: Yes
