Thomas Tauber-Marshall has posted comments on this change. Change subject: Initial structure for the C++ hiveserver2 client. ......................................................................
Patch Set 5: (2 comments) There are obviously still more tests to be added, but I have most of the basics so I figured I would upload what I have. http://gerrit.cloudera.org:8080/#/c/2645/5/src/hs2client/columnar-row-set.cc File src/hs2client/columnar-row-set.cc: Line 77: nulls = &impl_->column.boolVal.nulls; > You want here: Done http://gerrit.cloudera.org:8080/#/c/2645/5/src/hs2client/operation.cc File src/hs2client/operation.cc: Line 30: Operation::Operation(shared_ptr<ThriftRPC> rpc) > I would use const std::shared_ptr<ThriftRPC>& rpc here and skip the std::mo Done -- To view, visit http://gerrit.cloudera.org:8080/2645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7be82d5897ad6093116915b17924674c4ae508a0 Gerrit-PatchSet: 5 Gerrit-Project: hs2client Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wes McKinney <[email protected]> Gerrit-HasComments: Yes
