Lars Volker has posted comments on this change.

Change subject: IMPALA-3327: Disable metric validation for backend clients
......................................................................


Patch Set 4:

(3 comments)

Thanks for the review. I uploaded PS5.

http://gerrit.cloudera.org:8080/#/c/2788/4//COMMIT_MSG
Commit Message:

Line 12: queuing effects
> what queuing effects?
>From looking at the number of TransmitData() calls it seems that new calls are 
>made after old ones timed out. Should I reword this? Do we need to investigate 
>why this happens exactly? If it wasn't for that, we'd still expect timeouts of 
>2 minutes, more than the default wait time of the test (1min).


http://gerrit.cloudera.org:8080/#/c/2788/4/tests/verifiers/metric_verifier.py
File tests/verifiers/metric_verifier.py:

Line 22: for
> delete
Done


Line 22: for
> Also, what's the plan for re-enabling this?
I don't know. Henry mentioned having some ideas to reduce the zombie period in 
the Jira, but not in 5.8.


-- 
To view, visit http://gerrit.cloudera.org:8080/2788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67e8c5bd8ab4f71a3c10e9387ae165c0c1dd30f3
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Jim Apple <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-HasComments: Yes

Reply via email to