Matthew Jacobs has posted comments on this change. Change subject: Updates for new Kudu toolchain layout and upgrade Kudu ......................................................................
Patch Set 4: (3 comments) Cool, thanks! So I take it this only works on this 0.8-rc1 and forward? http://gerrit.cloudera.org:8080/#/c/2720/4/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: Line 125: build_kudu_stub might be worth putting this big kudu-specific fn in a separate file. feel free to ignore for now. Line 158: override nit: overridden Line 167: stub nit: can we make this more clear and more obvious it's some special thing, e.g. "__IMPALA_KUDU_STUB__"? -- To view, visit http://gerrit.cloudera.org:8080/2720 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I625903bd92afece0ad819a96fc275d5812b5eb2a Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
