Tim Armstrong has posted comments on this change. Change subject: IMPALA-1578: fix text scanner to handle "\r\n" delimiters split across blocks ......................................................................
Patch Set 1: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/2803/1/be/src/exec/hdfs-text-scanner.cc File be/src/exec/hdfs-text-scanner.cc: Line 646: /*peek*/ Nit: we mostly don't comment arguments like this. http://gerrit.cloudera.org:8080/#/c/2803/1/be/src/exec/hdfs-text-scanner.h File be/src/exec/hdfs-text-scanner.h: Line 39: /// A special case is a "\r\n" row delimiter split across two scan ranges. In this case, I think one bit of info is missing: it seems like having "\n" as the delimiter is somewhat of a special case, because it implies that "\r" and "\r\n" are also delimiters. If you have a different row delimiter, none of that stuff happens, right? http://gerrit.cloudera.org:8080/#/c/2803/1/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: Line 423: # Create table Nit: comment is not very informative, could remove. Line 430: # Create a datafile that will exercise interesting edge cases assuming 4-byte scan Maybe this should be the method comment? This is ok, just a thought. -- To view, visit http://gerrit.cloudera.org:8080/2803 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id42b441674bb21517ad2788b99942a4b5dc55420 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
