Casey Ching has posted comments on this change. Change subject: IMPALA-3368: Fix race in test_scratch_disk.py ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/2817/2//COMMIT_MSG Commit Message: Line 7: IMPALA-3368: Fix race in test_scratch_disk.py Maybe describe the race? Seems like the problem is that xdist is spinning up multiple processes, and each process tries to create the same temp dirs when the class is defined. With your change each process creates a randomly named dir to avoid the conflict. http://gerrit.cloudera.org:8080/#/c/2817/2/tests/custom_cluster/test_scratch_disk.py File tests/custom_cluster/test_scratch_disk.py: Line 87: super(CustomClusterTestSuite, self).setup_class() It's probably best to choose either class level setup/teardown or method level setup/teardown. Now it's mixed and I think what'll happen is, at every test run a new set of dirs will be generated (because the setup is at the method level) but only the last set of dirs will be deleted (because the cleanup is at the class level). Maybe just have the method body just "pass" to prevent the parent class setup? -- To view, visit http://gerrit.cloudera.org:8080/2817 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0764843ace00aef8c9b01139906e01ab5213047 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
