Casey Ching has posted comments on this change. Change subject: Kudu merge: Consolidate checkTypeCompatibility() ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/2808/3/fe/src/main/java/com/cloudera/impala/analysis/StatementBase.java File fe/src/main/java/com/cloudera/impala/analysis/StatementBase.java: Line 119: if (dstColType.equals(srcExprType) && !dstColType.isComplexType()) return srcExpr; > i don't think the check for complex types should be done in this function, How about I change the line so it is only if (colType.equals(exprType)) return expr; I think it was impossible to hit that check anyways. The only callers are from insert/update statements. Since it's impossible to write a literal complex type or to select a complex type, the check shouldn't be needed. A precondition check could be done instead to make a little more future-proof. Also this code was like this before the Kudu merge. I don't want this post-merge cleanup to expand into cleaning up misc unrelated things. -- To view, visit http://gerrit.cloudera.org:8080/2808 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb3d5d8749dca340e0a6f20d17a2a4f5033a0595 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
