Tim Armstrong has posted comments on this change. Change subject: IMPALA-3354: bad sorter pivot selection on some inputs ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2824/2/be/src/runtime/sorter.cc File be/src/runtime/sorter.cc: Line 242: TupleIterator(TupleSorter* parent, int64_t index) > could you add a function comment for the constructor? i.e. what inputs are I'm working on another patch that cleans up the iterator amongst other things so I'll do that in there, if that's ok? -- To view, visit http://gerrit.cloudera.org:8080/2824 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae50112b6deca3d6268e18b6f4daae1af279b452 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
