Casey Ching has posted comments on this change. Change subject: Build Kudu from source ......................................................................
Patch Set 7: (4 comments) Did you want Tim to look at this too? http://gerrit.cloudera.org:8080/#/c/2679/7//COMMIT_MSG Commit Message: Line 15: One downside is there is no longer a clear path to building a stubbed : client on an unsupported OS. Building the stub is a two step process, : that first requires a real client to be built. Since step one cannot be : done on an unsupported OS, the build would need to use artifacts built : on another OS. The expected solution is that users who need the stubs : will build the stubs themselves. > outdated now I'm not sure what you mean. This is really what happened. The "user who needs the stubs" is the Impala build and it builds the stubs itself. http://gerrit.cloudera.org:8080/#/c/2679/7/source/kudu/build.sh File source/kudu/build.sh: Line 82: if needs_build_package ; then > can we reverse this and exit early? save some indenting as this is a huge b Done Line 97: fing > find Done Line 98: system > systems Done -- To view, visit http://gerrit.cloudera.org:8080/2679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ec8494fb4e765ec796b31212c811af34e8514bd Gerrit-PatchSet: 7 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
