Marcel Kornacker has posted comments on this change. Change subject: IMPALA-1740: Add support for skip.header.line.count. ......................................................................
Patch Set 19: (4 comments) http://gerrit.cloudera.org:8080/#/c/2110/19/fe/src/main/java/com/cloudera/impala/analysis/AlterTableSetTblProperties.java File fe/src/main/java/com/cloudera/impala/analysis/AlterTableSetTblProperties.java: Line 123: * formats that support it, and make sure that it is set to a valid value. update comment http://gerrit.cloudera.org:8080/#/c/2110/19/fe/src/main/java/com/cloudera/impala/analysis/CreateTableStmt.java File fe/src/main/java/com/cloudera/impala/analysis/CreateTableStmt.java: Line 201: if (analyzer.dbContainsTable(tableName_.getDb(), tableName_.getTbl(), Privilege.CREATE) long line Line 246: AlterTableSetTblProperties.analyzeSkipHeaderLineCount(tblProperties_, true); you're passing in a constant for is_hdfs_tbl http://gerrit.cloudera.org:8080/#/c/2110/19/fe/src/main/java/com/cloudera/impala/catalog/HdfsTable.java File fe/src/main/java/com/cloudera/impala/catalog/HdfsTable.java: Line 1228: "must be integer >= 0)", key, string_value); sorry, "an integer" -- To view, visit http://gerrit.cloudera.org:8080/2110 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I595f01a165d41499ca1956fe748ba3840a6eb543 Gerrit-PatchSet: 19 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-HasComments: Yes
