Tim Armstrong has posted comments on this change. Change subject: Fix ConcurrentTimerCounter unit test "TimerCounterTest" failure. ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2838/2/be/src/util/runtime-profile-test.cc File be/src/util/runtime-profile-test.cc: Line 614: if (!(stopwatch_value >= expected_value - TimerCounterTest::MAX_TIMER_ERROR_NS && > Log the timer error if it is larger than the TimerCounterTest::MAX_TIMER_ER If you use EXPECT_LE and EXPECT_GE to check the conditions it will log the values for you. -- To view, visit http://gerrit.cloudera.org:8080/2838 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I807a774da27ff6215f790ec44c9706fa6f95639f Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Juan Yu <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
