Casey Ching has posted comments on this change. Change subject: Simplify creating external Kudu tables and add DROP DATABASE CASCADE ......................................................................
Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/2617/3//COMMIT_MSG Commit Message: Line 23: KUDU as a file format > Yeah, I'm wondering if you've chatted with them about what they're planning Just sent an email to Lenni/you about this. http://gerrit.cloudera.org:8080/#/c/2617/3/fe/src/main/java/com/cloudera/impala/analysis/CreateTableStmt.java File fe/src/main/java/com/cloudera/impala/analysis/CreateTableStmt.java: Line 298: rowFormat_ = RowFormat.DEFAULT_ROW_FORMAT; > Yeah, keeping it null seems fine as long as whatever code that reads it lat Done. The tests seem to pass. http://gerrit.cloudera.org:8080/#/c/2617/3/fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java File fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java: Line 1129: For : // now Impala will assume that any table not in its cache also doesn't require the : // use of a DdlDelegate. > Have you chatted with the Hive team about their kudu integration plans? We Not yet, just asked about this in the email. http://gerrit.cloudera.org:8080/#/c/2617/3/testdata/workloads/functional-query/queries/QueryTest/kudu-show-create.test File testdata/workloads/functional-query/queries/QueryTest/kudu-show-create.test: Line 9: ) > Ah yes, but that's not the only thing: also that this comes back with the s Done http://gerrit.cloudera.org:8080/#/c/2617/3/tests/conftest.py File tests/conftest.py: Line 264: conn > If you don't mind pulling test infra stuff into a separate review I think i Done -- To view, visit http://gerrit.cloudera.org:8080/2617 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic141102818b6dad3016181b179a14024d0ff709d Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
