Tim Armstrong has posted comments on this change. Change subject: Updates for new Kudu toolchain layout and upgrade Kudu ......................................................................
Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/2720/9/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: Line 188: if sym_type.upper() in "TW": I don't think this is right. I ran this: nm --defined-only -D ./debug/lib/libkudu_client.so | less And I'm seeing a bunch of symbols that clearly aren't kudu-specific. 00000000000b6fb2 W _ZN5boost16exception_detail10clone_baseC1ERKS1_ 00000000000bafd4 W _ZN5boost16exception_detail10clone_baseC1Ev 00000000000b6fb2 W _ZN5boost16exception_detail10clone_baseC2ERKS1_ 00000000000bafd4 W _ZN5boost16exception_detail10clone_baseC2Ev 00000000001b8e58 W _ZN5boost16exception_detail19error_info_injectorISt16invalid_argumentEC1ERKS2_ 00000000001b8646 W _ZN5boost16exception_detail19error_info_injectorISt16invalid_argumentEC1ERKS3_ 00000000001b8e58 W _ZN5boost16exception_detail19error_info_injectorISt16invalid_argumentEC2ERKS2_ 00000000001b8646 W _ZN5boost16exception_detail19error_info_injectorISt16invalid_argumentEC2ERKS3_ 00000000001b8a0c W _ZN5boost16exception_detail19error_info_injectorISt16invalid_argumentED0Ev 00000000001b899e W _ZN5boost16exception_detail19error_info_injectorISt16invalid_argumentED1Ev 00000000001b899e W _ZN5boost16exception_detail19error_info_injectorISt16invalid_argumentED2Ev 00000000000b707a W _ZN5boost9exceptionC1ERKS0_ 00000000000b707a W _ZN5boost9exceptionC2ERKS0_ 00000000000ae22e W _ZN5boost9exceptionD0Ev 00000000000ae1e8 W _ZN5boost9exceptionD1Ev 00000000000ae1e8 W _ZN5boost9exceptionD2Ev 00000000001261de W _ZN9__gnu_cxx13new_allocatorIbEC1Ev 00000000001261de W _ZN9__gnu_cxx13new_allocatorIbEC2Ev 00000000001261e8 W _ZN9__gnu_cxx13new_allocatorIbED1Ev 00000000001261e8 W _ZN9__gnu_cxx13new_allocatorIbED2Ev 0000000000255650 W _ZN9__gnu_cxx13new_allocatorIcE10deallocateEPcm 0000000000252e36 W _ZN9__gnu_cxx13new_allocatorIcE7destroyIcEEvPT_ 000000000025711c W _ZN9__gnu_cxx13new_allocatorIcE8allocateEmPKv etc -- To view, visit http://gerrit.cloudera.org:8080/2720 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I625903bd92afece0ad819a96fc275d5812b5eb2a Gerrit-PatchSet: 9 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
