Casey Ching has posted comments on this change. Change subject: IMPALA-2883,IMPALA-3383: don't dump core when misconfigured. ......................................................................
Patch Set 1: > First, thanks a lot for fixing this. > > IMHO, this is a test bug not an Impala bug. If the test is > generating core which is causing timeout, may be we should just > disable core dumping for that test. It seems a bit 'reversed' to > contort the error handling logic of fatal error to appease the > test. While it's true that the log file may have recorded the > failure, the core file will still be helpful in the rare cases such > as bad hardware which ended up corrupting the startup options > memory. Disabling the core dumps during testing means if something goes wrong during the test then we won't get the core dump that could be useful. That seems like a more likely scenario than bad hardware leading to memory corruption. Probably better to prioritize that. -- To view, visit http://gerrit.cloudera.org:8080/2862 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1686bf72df9420512e14af1a55279a064b633c9 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: No
