Henry Robinson has posted comments on this change. Change subject: IMPALA-3306: Add command-line flags to set S3 access configurations ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/2850/3/be/src/common/init.cc File be/src/common/init.cc: Line 210: EXIT_IF_ERROR(impala::HdfsFsCache::Init()); > Could you point me to that patch? I'm not sure which one it is. This one: http://gerrit.cloudera.org:8080/#/c/2862/ http://gerrit.cloudera.org:8080/#/c/2850/3/be/src/util/os-util.cc File be/src/util/os-util.cc: Line 112: do_trim > Currently there aren't. Do you think it's better to remove this condition a I would prefer not: callers might reasonably expect that RunShellProcess() returns the verbatim output from a command unless explicitly told not to. -- To view, visit http://gerrit.cloudera.org:8080/2850 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ba103bcb399861683066fd00219d30c180db043 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
