Matthew Jacobs has posted comments on this change. Change subject: Simplify creating external Kudu tables and add DROP DATABASE CASCADE ......................................................................
Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/2617/7/fe/src/main/java/com/cloudera/impala/analysis/CreateTableStmt.java File fe/src/main/java/com/cloudera/impala/analysis/CreateTableStmt.java: Line 308: tblProperties_ > Sure. I just pointed it out because it's inconsistent with the interface. T BTW how are you tracking things like this that you're planning on doing in follow-up patches? http://gerrit.cloudera.org:8080/#/c/2617/7/fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java File fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java: Line 1541: setDistributeParams(distributeBy) > This entire "ddl delegate" thing seems premature considering there is only so this is something you'll address in a follow-up patch then? http://gerrit.cloudera.org:8080/#/c/2617/7/tests/query_test/test_kudu.py File tests/query_test/test_kudu.py: Line 145: cursor.execute(""" : CREATE EXTERNAL TABLE %s : STORED AS KUDU : TBLPROPERTIES('kudu.table_name' = '%s')""" % ( : impala_table_name, preferred_kudu_table.name)) > I'm not sure I follow, hasn't the user given an explicit name here? Why wou Ah, I was confused about how the test case works. Thanks. -- To view, visit http://gerrit.cloudera.org:8080/2617 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic141102818b6dad3016181b179a14024d0ff709d Gerrit-PatchSet: 7 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
