Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3383: don't dump core when misconfigured. ......................................................................
IMPALA-3383: don't dump core when misconfigured. Calling LOG(FATAL) calls abort(), which will generate a core dump in many cases. This is sometimes useful, but sometimes not (e.g. if we were just passed a bad command-line argument, we know what the problem is from the log message). This patch adds a CLEAN_EXIT_WITH_ERROR macro that logs to the ERROR log, flushes it, and then exits the process with exit code 1. This prevents custom cluster tests from generating unnecessary core dumps. Change-Id: If1686bf72df9420512e14af1a55279a064b633c9 Reviewed-on: http://gerrit.cloudera.org:8080/2862 Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Internal Jenkins --- M be/src/catalog/catalog.cc M be/src/catalog/catalogd-main.cc M be/src/common/init.cc M be/src/common/status.h M be/src/exprs/expr-benchmark.cc M be/src/exprs/expr-test.cc M be/src/scheduling/request-pool-service.cc M be/src/service/frontend.cc M be/src/service/impala-server.cc M be/src/service/impalad-main.cc M be/src/statestore/statestored-main.cc M be/src/testutil/in-process-servers.cc M be/src/testutil/mini-impala-cluster.cc 13 files changed, 84 insertions(+), 67 deletions(-) Approvals: Internal Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/2862 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1686bf72df9420512e14af1a55279a064b633c9 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
