Dan Hecht has posted comments on this change. Change subject: IMPALA-1878: Support INSERT and LOAD DATA on S3 and between filesystems ......................................................................
Patch Set 23: (4 comments) http://gerrit.cloudera.org:8080/#/c/2574/23/be/src/util/hdfs-util.cc File be/src/util/hdfs-util.cc: Line 81: This is a helper function and is not declared in the header file. It returns Returns (the first sentence is obvious). Line 88: file Let's check for "file:" since there could conceivable be a scheme called fileotherstuff, and change both 4 to 5s. Also, this case should come first, so that "file:path" works okay. And then I think after_scheme should be at occurrence of "://" since we're assuming the second slash below (3 characters). Line 90: after_scheme + 3 this is missing the dereference. please add a test case to your unit test that catches this bug. Line 94: after_authority - path is this off by one? i.e. hdfs://n/ should return 7, right? It think this test case would catch the bug: hdfs://namenode hdfs://namenode/ should compare equal but i think FilesystemMatch() currently false in that case? -- To view, visit http://gerrit.cloudera.org:8080/2574 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94e15ad67752dce21c9b7c1dced6e114905a942d Gerrit-PatchSet: 23 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
