Sailesh Mukil has posted comments on this change. Change subject: IMPALA-1878: Support INSERT and LOAD DATA on S3 and between filesystems ......................................................................
Patch Set 24: (2 comments) http://gerrit.cloudera.org:8080/#/c/2574/24/be/src/util/hdfs-util-test.cc File be/src/util/hdfs-util-test.cc: Line 58: EXPECT_TRUE(FilesystemsMatch("hdfs://namenode/temp_dir/temp_path", "hdfs://")); > Should be two non-zero lengths, so still don't see why they compare true. Oops, my bad. I think I ran the tests without building the test file. That test case is wrong. I've removed it. http://gerrit.cloudera.org:8080/#/c/2574/24/tests/metadata/test_ddl.py File tests/metadata/test_ddl.py: Line 70: @SkipIfS3.qualified_path > okay. let's change this to SkipIfS3.jra(3459) or whatever the syntax is the I looked up what PURGE is supposed to do and it ultimately just calls a "hadoop fs -rm -skipTrash [filename]". The only extra thing being -skipTrash. That on an S3 path has no effect, so it's the same as DROP TABLE. I've changed it to SkipIfS3.hdfs_purge. -- To view, visit http://gerrit.cloudera.org:8080/2574 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94e15ad67752dce21c9b7c1dced6e114905a942d Gerrit-PatchSet: 24 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
