Henry Robinson has posted comments on this change. Change subject: IMPALA-3159: Enable SAN / wildcard certificate support in shell ......................................................................
Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/2906/1/be/src/testutil/wildcard-cert.pem File be/src/testutil/wildcard-cert.pem: Line 1: -----BEGIN CERTIFICATE----- > Looking at the contents of the cert, it looks to be valid only for a month. Thanks for catching that. I've made the certificate last for 30 years. http://gerrit.cloudera.org:8080/#/c/2906/1/tests/custom_cluster/test_client_ssl.py File tests/custom_cluster/test_client_ssl.py: Line 1: 2012 > 2016 Done Line 15: Tests for query expiration. > Not relevant Done Line 34: SSL is enabled > Better to make it a constant? Repeated multiple times. (Others below too). Done Line 63: "--ssl_private_key=%s/server-key.pem" > Should there be a test for password protected private key too? (be/src/test Not here - it's covered in thrift-server-test.cc http://gerrit.cloudera.org:8080/#/c/2906/1/tests/shell/test_shell_common.py File tests/shell/test_shell_common.py: Line 83: run_impala_shell_cmd > Should this go into tests/util/shell_util.py ? The current file seems to be Renamed the file to util. -- To view, visit http://gerrit.cloudera.org:8080/2906 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie47d6e02fc856b73f531b6ac49b1bab0976a8396 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-HasComments: Yes
