Lars Volker has posted comments on this change. Change subject: IMPALA-2686: Add breakpad crash handler to all daemons ......................................................................
Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/2028/12/tests/custom_cluster/test_breakpad.py File tests/custom_cluster/test_breakpad.py: Line 76: time.sleep(1) > just that it's timing sensitive. maybe if the system is overcommitted it co We only rely on the minidump being written, which should not take that long. Writing a core will happen afterwards, but we don't rely on that being completed. Process.restart() from tests/common/impala_cluster.py::Process does the same, so I assume it is the way to go: def restart(self): """Kills and restarts the process""" self.kill() # Wait for a bit so the ports will be released. sleep(1) self.start() -- To view, visit http://gerrit.cloudera.org:8080/2028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a37a38488716ffe34296f3490ae291bbb7228d6 Gerrit-PatchSet: 12 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Silvius Rus <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
