Michael Brown has posted comments on this change. Change subject: Use unique_database fixture in test_compute_stats.py. ......................................................................
Patch Set 2: (1 comment) Looks good! I think you should call out in the commit message that it's possible to use unique_database with .test files, at least if they are crafted correctly. http://gerrit.cloudera.org:8080/#/c/2947/2/tests/metadata/test_compute_stats.py File tests/metadata/test_compute_stats.py: Line 56: def test_compute_stats_keywords(self, vector): : """IMPALA-1055: Tests compute stats with a db/table name that are keywords.""" : self.execute_query("create database `parquet`") Do you need to drop `parquet` if it exists first? -- To view, visit http://gerrit.cloudera.org:8080/2947 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8655eb769003f88c0e1ec1b254118e4ec3353b48 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
