Dan Hecht has posted comments on this change. Change subject: IMPALA-1578: fix text scanner to handle "\r\n" delimiters split across blocks ......................................................................
Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/2803/4/be/src/exec/hdfs-text-scanner.cc File be/src/exec/hdfs-text-scanner.cc: Line 256: with on the '\r' of a "\r\n" delimiter Line 604: if (!eosr) continue; this would be easier to read if it were: if (eosr) break; and then 'break' at line 607 and then delete line 609. Line 615: DCHECK(*tuple_found); can't we get here with !*tuple_found if eosr is true? a missing test case? http://gerrit.cloudera.org:8080/#/c/2803/4/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: Line 446: def test_text_split_across_buffers_delimiter(self, vector, unique_database): add brief comment explaining this test case Line 470: check_call(['hadoop', 'fs', '-copyFromLocal', f.name, location]) does this overwrite if the file already exists? -- To view, visit http://gerrit.cloudera.org:8080/2803 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id42b441674bb21517ad2788b99942a4b5dc55420 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
