Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3452: S3: Disable Impala staging for INSERTs via flag for speedup ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/2905/3/be/src/exec/hdfs-table-sink.cc File be/src/exec/hdfs-table-sink.cc: Line 295: filename << output_partition->tmp_hdfs_file_name_prefix : << "." << output_partition->num_files : << "." << output_partition->writer->file_extension(); > mixing your metaphors a bit :) Convert this to Substitute() as well, and ju Oops, yup. Done. Line 342: stringstream dest; : dest << final_location; > dest is completely unnecessary now Sorry, looks like I was brain dead for the last patch set. Done. http://gerrit.cloudera.org:8080/#/c/2905/3/be/src/exec/hdfs-table-sink.h File be/src/exec/hdfs-table-sink.h: Line 95: skip_staging > rather than adding another field, can we just have a method in the table si A function would do a string comparison every time it's invoked (It's called about 3 times per partition). Also, it has to part of the HdfsTableSink class (to access the overwrite_ member). I've done it in this patch. If it doesn't look good, I can change it back to using the member variable (or modify the function itself based on the review). http://gerrit.cloudera.org:8080/#/c/2905/3/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: Line 216: // the files there. > Maybe add a TODO to fix this: could easily imagine a scheme where the coord Done -- To view, visit http://gerrit.cloudera.org:8080/2905 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff9620d41ba0d5fb1aa0c9f4abb48866fc2b0698 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
