Casey Ching has posted comments on this change. Change subject: IMPALA-3397: Source query files from shell. ......................................................................
Patch Set 6: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/2663/6/shell/impala_shell.py File shell/impala_shell.py: Line 1109: print_to_stderr('Not connected to Impala, could not execute query list.') If I saw this message I'd be confused as to what "query list" was referring to. Maybe just say "queries". If you really want to you could check to see the size of the queries param to use the singular form. Line 1190: query_text = "" I'm guessing this line handles the missing "else" case in the if/elif block below. If so this would be easier to read if else: return were used. Then this line could be removed. -- To view, visit http://gerrit.cloudera.org:8080/2663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib05df3e755cd12e9e9562de6b353857940eace03 Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-HasComments: Yes
