Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3488: test_ddl.py failure on LocalFS run ......................................................................
IMPALA-3488: test_ddl.py failure on LocalFS run Our test_ddl.py always had a bug where in the _cleanup() function, we used the hdfs_client on local FS runs. It always ended up passing because we caught generic exceptions in hdfs_client.delete_file_dir() while checking if a file existed which always caused the test to pass. With the introduction of an hdfs_client.exists() function in IMPALA-1878 which catches only the right FileNotFound exception, this bug was exposed causing our local FS runs to fail. This patch returns from the _cleanup() function if it's a local FS run because the directories of the tables it cleans up are not used in these runs. Change-Id: Ie0c9eec31a90e8f66102d18d900c613bd1306968 Reviewed-on: http://gerrit.cloudera.org:8080/2980 Reviewed-by: Alex Behm <[email protected]> Tested-by: Internal Jenkins --- M tests/metadata/test_ddl.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Internal Jenkins: Verified Alex Behm: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/2980 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0c9eec31a90e8f66102d18d900c613bd1306968 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]>
