Alex Behm has posted comments on this change. Change subject: Use unique_database fixture in test_col_stats.py. ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/2963/1/tests/metadata/test_compute_stats.py File tests/metadata/test_compute_stats.py: Line 149: "from functional.alltypes limit 10" % table_name) > Backslash not needed when a multi-line string literal is within parentheses Done Line 153: > Why did you remove the REFRESH that existed in the test before? The previous version of the test computed stats with an external script/client, so a refresh was needed to pick them up. Line 158: self.client.execute("invalidate metadata %s" % table_name) > Why did you add the invalidate metadata that was not in the test before? This test is guarding against regression of a bug where the Metastore contains column stats for a column that used to be a different (incompatible) type, and the failure happens when loading table metadata, so after changing the column type we force a metadata reload. Line 168: self.client.execute("compute stats %s" % table_name) > Another REFRESH removed after L168 (see L79-80 in the removed file). Same as above, compute stats is now done via self.client and not an external script. -- To view, visit http://gerrit.cloudera.org:8080/2963 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88aa77464a95993c018e19a52eeb496d7c3eef08 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
