Jim Apple has posted comments on this change. Change subject: IMPALA-3375: Improve TopN performance with a trivial Compare object. ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/2936/3/be/src/util/tuple-row-compare.h File be/src/util/tuple-row-compare.h: Line 38: /// ComparatorWrapper takes a reference to an object of type T, rather than copying that > update Done Line 46: template <typename X> > switch this to 'type T' (which ties in with your comment on l29) Done -- To view, visit http://gerrit.cloudera.org:8080/2936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24755227b5bbbca6ad7c7d31d9bb8e132ca89e11 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
