Alex Behm has posted comments on this change. Change subject: IMPALA-3491: Use unique_database fixture in test_recover_partitions.py. ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3003/1/tests/metadata/test_recover_partitions.py File tests/metadata/test_recover_partitions.py: Line 49: return 'test-warehouse/%s.db/%s/' % (db_name, table_name) > Don't you need to use get_fs_path() here? Good question. I originally did that, but it doesn't work because the filesystem_client appears to then also prepend a "/" and then complains about the path having two leading backslashes. Looks like some issue with the pywebhdfs lib and I could not find an easy fix for this problem. Also note that this is exactly what the test did before. Line 79: assert self.has_value(PART_NAME, result.data) == False > There are a lot of places in this test module that have lines like this: co Easy enough to do. Done. -- To view, visit http://gerrit.cloudera.org:8080/3003 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be5fa5d20bc6ed5b7830e0ce90201431d6aa008 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
