Jim Apple has posted comments on this change. Change subject: IMPALA-3507: Use toolchain linker only if using gold ......................................................................
Patch Set 2: > It would be good to confirm first with perf top that the time is > spent in elf_x86_64_convert_load - that's the problem according to > the bug. > > It would be nice to have a usable ld in the toolchain. Agreed. For the moment, I suggest we commit this patch to bring the build time back to earth, then upgrade bitutils and try again. -- To view, visit http://gerrit.cloudera.org:8080/3014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I822a78642993e95abc279944f454fdf67dd8e1d5 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
