Tim Armstrong has posted comments on this change. Change subject: IMPALA-3311: fix string data coming out of aggs in subplans ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/2929/1/be/src/exec/partitioned-aggregation-node.cc File be/src/exec/partitioned-aggregation-node.cc: Line 370: for (int i = 0; i < aggregate_evaluators_.size(); ++i) { > I moved the string copying code to its own function. Lemme know if you thin It would be good to factor this whole loop out, e.g. into HandleLocalStringAllocations() (or some other name, that's a little clunky). I think then we can bail out of the function early if (!needs_finalize_ && !needs_serialize_). Line 374: if (IsInSubplan()) { > I'm having trouble writing a good query that really isolates this effect an Thanks for doing this, it's good to confirm that there's a real effect. I also commented on the query file itself. -- To view, visit http://gerrit.cloudera.org:8080/2929 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iada891504c261ba54f4eb8c9d7e4e5223668d7b9 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
