Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3517: S3: Get rid of hdfsDelete() warning message ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3019/1/be/src/exec/hdfs-table-sink.cc File be/src/exec/hdfs-table-sink.cc: Line 509: !no_more_rows > not your change, but i don't understand why this is !no_more_rows (i.e. mor This basically says that we have some input, delete the temporary directory for that partition. This is versus the fact that if we didn't have any input for the partition (for e.g: a new partition), we wouldn't have any data in the temporary directory and so we wouldn't need to delete it because it would never be created in the first place. -- To view, visit http://gerrit.cloudera.org:8080/3019 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a81ba0abfc24ee56689211579f46ac353e98adb Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
