Thomas Tauber-Marshall has posted comments on this change. Change subject: Renamed conjunct_ordering.test to primitive_conjunct_ordering.test in targeted-perf ......................................................................
Patch Set 1: This change should work for reordering join conjuncts, not just scan conjuncts, but only conjuncts that appear in the same list, eg. hash predicates can be reordered with other hash predicates but not with "other" predicates. I'm not sure what you mean that the query is not valid. Our plan for the regular tcph-q19 query applies the predicates at the join also. The only change I made was adding another predicate, since the original query only has two, with one being a "hash" predicates and the other being an "other predicate so we couldn't reorder them. -- To view, visit http://gerrit.cloudera.org:8080/3021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica8db68141ef653b0b01a7cfa7773302717a35a2 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: No
