Dan Hecht has posted comments on this change.

Change subject: IMPALA-3502: Fix race in the coordinator while updating filter 
routing table
......................................................................


Patch Set 2: Code-Review+2

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3018/2/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:

Line 485: DCHECK
DCHECK_NE


Line 673: DCHECK
DCHECK_NE


Line 2003:   exec_complete_barrier_->Wait();
maybe add the OFF dcheck here as well.


-- 
To view, visit http://gerrit.cloudera.org:8080/3018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecc737106fd38aa4af0c72959a577adfb413728d
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Dimitris Tsirogiannis <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: Yes

Reply via email to