Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-2979: Fix scheduling on remote hosts
......................................................................


Patch Set 19:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2200/19/be/src/scheduling/simple-scheduler.h
File be/src/scheduling/simple-scheduler.h:

Line 327:   void SelectBackendOnHost(BackendMap::iterator entry, 
TBackendDescriptor* backend);
> Done. However it adds an additional indirection compared to 'const BackendM
depends on the implementation of the iterator. if you can assert that it's a 
scalar, you can pass it by value.


-- 
To view, visit http://gerrit.cloudera.org:8080/2200
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I044f83806fcde820fcb38047cf6b8e780d803858
Gerrit-PatchSet: 19
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Marcel Kornacker <[email protected]>
Gerrit-Reviewer: Mostafa Mokhtar <[email protected]>
Gerrit-Reviewer: anujphadke <[email protected]>
Gerrit-HasComments: Yes

Reply via email to