Jim Apple has posted comments on this change. Change subject: IMPALA-3534: allow overriding of CMAKE_CXX_COMPILER for ASAN ......................................................................
Patch Set 1: > I did an ASAN build with IMPALA_CXX_COMPILER overridden to point to > a distcc wrapper script. It works the same as in toolchain.cmake > > It doesn't change behaviour otherwise (since IMPALA_CXX_COMPILER is > set to "default" in bin/impala-config.sh). Could you test our ASAN Jenkins jobs with this change, but without changing IMPALA_CXX_COMPILER, too, just to be sure it doesn't change anything? I'm only interested int he compilation, not the actual rrunning of the ASAN tests. -- To view, visit http://gerrit.cloudera.org:8080/3050 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ab488182c46f9ccb1850a0a2b064653e7e3da26 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
