Michael Brown has posted comments on this change.

Change subject: CDH-39818: Add Breakpad minidump collection script
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2997/6/bin/collect_minidumps.py
File bin/collect_minidumps.py:

Line 160:     if not os.path.isdir(result):
        :       sys.exit(0)
> The minidump directory might be empty or not exist, that's ok.
Oh, of course. The abrupt exit confused me, but I get it now.


-- 
To view, visit http://gerrit.cloudera.org:8080/2997
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I85b3643133e28eca07507ac2a79acbf73128456f
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Ishaan Joshi <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Michael Brown <[email protected]>
Gerrit-Reviewer: Taras Bobrovytsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes

Reply via email to