Alex Behm has posted comments on this change. Change subject: IMPALA-3491: Use unique_database fixture in test_data_errors.py. ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3087/1/tests/data_errors/test_data_errors.py File tests/data_errors/test_data_errors.py: Line 127: FQ_TBL_NAME = "%s.%s" % (unique_database, 'scan_agg_timestamp') > what does FQ stand for? Also, why use capital letters? I don't think it's n FQ stands for fully-qualified. It's quite long to write out and we use the abbreviation in many places. Regarding all caps. Michael brought it up in a past CR that we should be consistent. There were a few cases where we used all caps for local constants, so we decided to adopt that. I'm not sure if we have a definitive style guide here. I don't feel too strongly either way - as long as it's consistent (and we're rolled out all caps in many places already). Michael, anything to add? -- To view, visit http://gerrit.cloudera.org:8080/3087 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8337daf499b90819a253b883fedaa55bd6b6630e Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
