Dan Hecht has posted comments on this change. Change subject: IMPALA-3499: Frontend cannot deserialize catalog-update topic more than 2GB. ......................................................................
Patch Set 4: We need to think this through carefully because breaking the metadata updates into smaller chunks may have subtle side-effects. Huaisi - how about starting simpler by making thrift not crash when the buffer length exceeds uint32? You showed me some paths that raise an exception in this case but it looks like this path was missing that check. We could add that check so that at least the update would be failed rather than impalad crashing. -- To view, visit http://gerrit.cloudera.org:8080/3067 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I176db25124a32944f2396ce8aafbed49cac95928 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
