Dan Hecht has posted comments on this change. Change subject: IMPALA-3546: don't die if sysconf() reports bogus cache info ......................................................................
Patch Set 1: (1 comment) > (1 comment) Yeah, I agree we're better off just removing the methods and members since it doesn't work on all systems. Otherwise, it's too easy for someone to start using it for another purpose without noticing this caveat. http://gerrit.cloudera.org:8080/#/c/3110/1/be/src/util/cpu-info.cc File be/src/util/cpu-info.cc: Line 146: << cache_line_sizes_[0] << "-byte L1 cache lines"; is this going to be more confusing than it's worth? in reality, the cache line size is always 64 byes, so issuing an error when the OS claims it's not seems like it will just worry people but not actually help. Maybe make it an INFO if you want to keep? -- To view, visit http://gerrit.cloudera.org:8080/3110 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4d61b05fe213028a7e9aaabe98adc2792b90e07 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
