Dan Hecht has posted comments on this change. Change subject: IMPALA-3242: Remove most usages of RuntimeState::SetMemLimitExceeded() ......................................................................
Patch Set 1: Code-Review+2 (3 comments) Please have Tim take a look as well. http://gerrit.cloudera.org:8080/#/c/3140/1/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: Line 1189: ()) should this also skip for IsMemLimitExceeded()? Okay to leave as is though. http://gerrit.cloudera.org:8080/#/c/3140/1/be/src/runtime/plan-fragment-executor.cc File be/src/runtime/plan-fragment-executor.cc: Line 533: . by MemTracker::MemLimitExceeded(). http://gerrit.cloudera.org:8080/#/c/3140/1/be/src/runtime/runtime-state.h File be/src/runtime/runtime-state.h: Line 243: /// generic "Memory limit exceeded" error. let's add a note here saying this is depricated and instead MemTracker::MemLimitExceeded() should be used and the error status should be returned. -- To view, visit http://gerrit.cloudera.org:8080/3140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0ca128c768d1e73713866e8c513a1b75e6b4b59 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-HasComments: Yes
