Michael Ho has posted comments on this change. Change subject: Use MemTracker::MemLimitExceeded() where appropriate ......................................................................
Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/3148/1/be/src/exec/nested-loop-join-node.cc File be/src/exec/nested-loop-join-node.cc: Line 85: 1) It'll be clearer if it's Bitmap::MemUsage(1). May be worth factoring it out into one variable. http://gerrit.cloudera.org:8080/#/c/3148/1/be/src/service/fragment-mgr.cc File be/src/service/fragment-mgr.cc: Line 48: Substitute("Instance $0 of plan fragment $1 of query $2 could not " : "start because the backend Impala daemon is over its memory limit", : PrintId(exec_params.fragment_instance_ctx.fragment_instance_id), : exec_params.fragment.display_name, : PrintId(exec_params.fragment_instance_ctx.query_ctx.query_id)) nit: it's slightly easier to read if this is factored out as a variable. -- To view, visit http://gerrit.cloudera.org:8080/3148 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77c37f86dd15ace39e28b5cc72d37bc8d4109041 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
