Alex Behm has posted comments on this change. Change subject: IMPALA-3574: Exception when filter target contains TupleIsNull predicate ......................................................................
Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/3147/1//COMMIT_MSG Commit Message: Line 7: IMPALA-3574: Exception when filter target contains TupleIsNull predicate Describe the fix rather than the bug Line 13: unwrap these exprs and replace exprs of the form IF(TupleIsNull, NULL, e) 'e' with 'e' http://gerrit.cloudera.org:8080/#/c/3147/1/fe/src/main/java/com/cloudera/impala/analysis/TupleIsNullPredicate.java File fe/src/main/java/com/cloudera/impala/analysis/TupleIsNullPredicate.java: Line 164: public static Expr unwrapExpr(Expr expr, Analyzer analyzer) { remove analyzer arg Line 166: ((FunctionCallExpr) expr).getFnName().getFunction().equals("if") && Might be a line or two more, but I think it's more readable if we have something like: if (expr instanceof FnCallExpr) { FunctionCallExpr fnCallExpr = (FnCallExpr) expr; List<Expr> args = fnCallExprgetParas(); etc.. } http://gerrit.cloudera.org:8080/#/c/3147/1/fe/src/main/java/com/cloudera/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/com/cloudera/impala/planner/RuntimeFilterGenerator.java: Line 242: Expr expr = TupleIsNullPredicate.unwrapExpr(targetExpr.clone(), analyzer); needs a brief comment targetExpr = TupleIsNullPredicate.unwrap() http://gerrit.cloudera.org:8080/#/c/3147/1/testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-propagation.test File testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-propagation.test: Line 1090: select distinct t1.int_col let's simplify this to the smallest possible repro, there's a lot going on in this query -- To view, visit http://gerrit.cloudera.org:8080/3147 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e3e207b4c8522283a1cd0d14be83d42eba58f5a Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-HasComments: Yes
