Tim Armstrong has posted comments on this change. Change subject: IMPALA-3572: FE unit test coverage report with Jacoco. ......................................................................
Patch Set 1: (3 comments) Thanks for doing this, I've used jacoco in the past and it worked pretty well. http://gerrit.cloudera.org:8080/#/c/3151/1/bin/run-all-tests.sh File bin/run-all-tests.sh: Line 62: 0 Use true/false for consistency with the rest of the script. It might also be simpler just to use an environment variable, like the ones above. E.g. GENERATE_COVERAGE_REPORTS Line 65: c: Why not just make it an argument without a parameter (c instead of c:) http://gerrit.cloudera.org:8080/#/c/3151/1/fe/pom.xml File fe/pom.xml: Line 566: <skip>${jacoco.skip}</skip> Is it hard to invert the condition? It seems weird to enable something by setting skip=false. Feel free to ignore if there isn't a straightforward way to do it - maven is weird. -- To view, visit http://gerrit.cloudera.org:8080/3151 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5e4f1b8afb91210d40622aadd3d21d7ed94c2a7 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
