Alex Behm has posted comments on this change. Change subject: IMPALA-3454: Kudu deletes may fail if subqueries are used ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/2901/1/fe/src/main/java/com/cloudera/impala/analysis/ModifyStmt.java File fe/src/main/java/com/cloudera/impala/analysis/ModifyStmt.java: Line 87: // END: Members that need to be reset() move above referencedColumns_ http://gerrit.cloudera.org:8080/#/c/2901/1/testdata/workloads/functional-query/queries/QueryTest/kudu_crud.test File testdata/workloads/functional-query/queries/QueryTest/kudu_crud.test: Line 260: # Regression test for IMPALA-3454: A delete that requires a rewrite may not get the Kudu remove "Regression test for" and just have IMPALA-3454: Line 261: # column orders correct if the Kudu columns are of different types. column order Line 263: (key_1 tinyint, key_2 bigint) an end-to-end test is fine, but is there a way we could have caught this earlier, e.g., when creating the table sink, or after analyzing the stmt? -- To view, visit http://gerrit.cloudera.org:8080/2901 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55b6fecfd35458fbb5bc20b4be1375484d7bc3c6 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-HasComments: Yes
