Jim Apple has posted comments on this change. Change subject: IMPALA-2809: improve ByteSwap with builtin function or SSE or AVX2 ......................................................................
Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/3081/5/be/src/benchmarks/bswap-benchmark.cc File be/src/benchmarks/bswap-benchmark.cc: Line 36: // Impala: the old Impala implementation. I'm sorry, but this is still confusing. What does "old" mean, here? Is Bswap defined here or elsewhere? Please be more specific. http://gerrit.cloudera.org:8080/#/c/3081/5/be/src/util/bit-util.inline.h File be/src/util/bit-util.inline.h: Line 161: template <int template_data_width> template params should be in caps, like a constant. We follow https://google.github.io/styleguide/cppguide.html , mostly. Line 167: if(len >= 16) data_width = 16; Please put both branches of a conditional inside {} Line 174: SIMDFuncTable I think you can make this an actual function parameter, which might compile down to faster code. -- To view, visit http://gerrit.cloudera.org:8080/3081 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I392ed5a8d5683f30f161282c228c1aedd7b648c1 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Youwei Wang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Youwei Wang <[email protected]> Gerrit-HasComments: Yes
